-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Add a delay to last fabric remove action #29844
Merged
mergify
merged 1 commit into
project-chip:master
from
ArekBalysNordic:remove_last_fabric_fix
Oct 19, 2023
Merged
[nrfconnect] Add a delay to last fabric remove action #29844
mergify
merged 1 commit into
project-chip:master
from
ArekBalysNordic:remove_last_fabric_fix
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, a last fabric removal action should be delayed to avoid race conditions and allow the device to finish all currently running tasks. To control the delay use the CHIP_LAST_FABRIC_REMOVED_ACTION_DELAY kconfig. By default it has been set to 500 ms.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
October 18, 2023 11:21
pullapprove
bot
requested review from
yufengwangca,
tehampson,
yunhanw-google,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
October 18, 2023 11:21
pullapprove
bot
added
examples
platform
config
and removed
examples
platform
config
labels
Oct 18, 2023
PR #29844: Size comparison from 6b64a80 to 86ab9dc Increases (14 builds for nrfconnect)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 19, 2023
kkasperczyk-no
approved these changes
Oct 19, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…9844) In some cases, a last fabric removal action should be delayed to avoid race conditions and allow the device to finish all currently running tasks. To control the delay use the CHIP_LAST_FABRIC_REMOVED_ACTION_DELAY kconfig. By default it has been set to 500 ms.
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…9844) In some cases, a last fabric removal action should be delayed to avoid race conditions and allow the device to finish all currently running tasks. To control the delay use the CHIP_LAST_FABRIC_REMOVED_ACTION_DELAY kconfig. By default it has been set to 500 ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a last fabric removal action should be delayed to avoid race conditions and allow the device to finish all currently running tasks.
To control the delay use the
CHIP_LAST_FABRIC_REMOVED_ACTION_DELAY kconfig. By default, it has been set to 500 ms.